CMake unconsistent library naming

EdB
Posts: 2
Joined: Tue Aug 19, 2008 7:48 am

CMake unconsistent library naming

Post by EdB »

Using cmake to generate library file called libLibXXX. This doesn't match Jam and autotools naming scheme.

Please find attached a patch for current svn in order to make it consistent and looking like the traditionnal unix naming scheme

PS : I can't attached .patch nor .txt file ...
User avatar
Erwin Coumans
Site Admin
Posts: 4221
Joined: Sun Jun 26, 2005 6:43 pm
Location: California, USA

Re: CMake unconsistent library naming

Post by Erwin Coumans »

Thanks, I removed the embedded code and saved it in a cmake.patch file, but it doesn't work. (chunk size didn't match number of added/removed lines). Can you use Windows/TortoiseSVN to create the patch?

Can you please attach a patch in the Google issue tracker?
http://code.google.com/p/bullet/issues/list

Thanks a lot,
Erwin

By the way, this forum supports attaching zipped files, so you can also zip your patch. But http://code.google.com/p/bullet/issues/list is recommended
EdB
Posts: 2
Joined: Tue Aug 19, 2008 7:48 am

Re: CMake unconsistent library naming

Post by EdB »

I guess is due to blank line missing at the end (you should have 2 new line after the last braket)
But the way I will post it on http://code.google.com/p/bullet/issues/list but I know that you prefer to discuss thing on forum before.

The patch was create using svn diff, I don't use windows

Issue : http://code.google.com/p/bullet/issues/detail?id=108