void* -> int cast in btCompoundCollisionAlgorithm.cpp

[sparkprime]

Line 144 has

Code: Select all

int index = int(leaf->data);

Gcc will generate an error here on 64 bit platforms. One solution is to use long instead of int. However the better solution is probably to templatise btDbvtNode so that the data variable is the right type in the first place. This could also be used to avoid the union. This may result in some small memory savings and the code would generally be more elegant.

Any thoughts?

[Erwin Coumans]

It has been fixed now, keeping is simple:

Code: Select all

union	{
	btDbvtNode*	childs[2];
	void*	data;
	int		dataAsInt;
};

Templatizing this would be cumbersome and we can't justify the hassle,

Thanks for the feedback,
Erwin