Bug fix for btOptimizedBvh

[ole.k]

btOptimizedBvh::updateBvhNodes uses the variable curNodeSubPart to remember which part of a mesh is currently locked. If the part of the current node differs from curNodeSubPart, the old part has to be unlocked and the new one has to be locked. But the assignment of the new part index to curNodeSubPart is missing. The assignment

curNodeSubPart = nodeSubPart;

has to be added within

if (nodeSubPart != curNodeSubPart)
{
...
}

[Erwin Coumans]

We changed it into:

Code: Select all

 if (nodeSubPart != curNodeSubPart)
{
	if (curNodeSubPart >= 0)
	meshInterface->unLockReadOnlyVertexBase(curNodeSubPart);
	meshInterface->getLockedReadOnlyVertexIndexBase(&vertexbase,numverts, type,stride,&indexbase,indexstride,numfaces,indicestype,nodeSubPart);

	curNodeSubPart = nodeSubPart;
	btAssert(indicestype==PHY_INTEGER||indicestype==PHY_SHORT);
}

Can you double check this is correct?
Thanks,
Erwin

[ole.k]

Can you double check this is correct?
Thanks,
Erwin

Yes, it looks correct.